[batch] Fix async exit stacks #13969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danking
reviewed
Nov 2, 2023
| @@ -161,18 +165,21 @@ def inst_coll_manager(self) -> InstanceCollectionManager: | |||
|
|
|||
| async def shutdown(self) -> None: | |||
There was a problem hiding this comment.
Needn't be this PR, but this should use an exit stack as well.
daniel-goldstein
approved these changes
Nov 2, 2023
batch/batch/worker/worker.py
Outdated
| t.print_stack() | ||
| t.cancel() | ||
| if asyncio.all_tasks(): | ||
| other_tasks = [t for t in asyncio.all_tasks() if t != asyncio.current_task()] |
There was a problem hiding this comment.
I think this if is equivalent to what was there before.
There was a problem hiding this comment.
you're right. it was a different part of the stack trace that was throwing an almost identical error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find the best issue for this. Should fix #13908, but I thought there was another issue about reducing noisy grafana alerts which this PR also addresses.