Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[query] Add semhash support for Table-to-Table Aggregations #13922

Merged
merged 1 commit into from
Oct 31, 2023
Merged

[query] Add semhash support for Table-to-Table Aggregations #13922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions hail/src/main/scala/is/hail/expr/ir/analyses/SemanticHash.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,13 @@ case object SemanticHash extends Logging {
val getFieldIndex = table.typ.rowType.fieldIdx
keys.map(getFieldIndex).foreach(buffer ++= Bytes.fromInt(_))


case TableKeyByAndAggregate(_, _, _, nPartitions, bufferSize) =>
nPartitions.foreach {
buffer ++= Bytes.fromInt(_)
}
buffer ++= Bytes.fromInt(bufferSize)

case TableJoin(_, _, joinop, key) =>
buffer ++= joinop.getBytes ++= Bytes.fromInt(key)

Expand Down Expand Up @@ -339,6 +346,7 @@ case object SemanticHash extends Logging {
_: StreamTakeWhile |
_: TableGetGlobals |
_: TableAggregate |
_: TableAggregateByKey |
_: TableCollect |
_: TableCount |
_: TableDistinct |
Expand Down
6 changes: 4 additions & 2 deletions hail/src/test/scala/is/hail/expr/ir/analyses/SemanticHashSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ class SemanticHashSuite extends HailSuite {
)

def isTableIRSemanticallyEquivalent: Array[Array[Any]] = {
val ttype = TableType(TStruct("a" -> TInt32, "b" -> TStruct()), IndexedSeq(), TStruct())
val ttype = TableType(TStruct("a" -> TInt32, "b" -> TStruct()), IndexedSeq("a"), TStruct())
val ttypeb = TableType(TStruct("c" -> TInt32, "d" -> TStruct()), IndexedSeq(), TStruct())

def mkTableRead(reader: TableReader): TableIR =
Expand Down Expand Up @@ -205,12 +205,14 @@ class SemanticHashSuite extends HailSuite {
Array(
TableGetGlobals,
TableAggregate(_, Void()),
TableAggregateByKey(_, MakeStruct(FastSeq())),
TableKeyByAndAggregate(_, MakeStruct(FastSeq()), MakeStruct(FastSeq("idx" -> I32(0))), None, 256),
TableCollect,
TableCount,
TableDistinct,
TableFilter(_, Void()),
TableMapGlobals(_, MakeStruct(IndexedSeq.empty)),
TableMapRows(_, MakeStruct(IndexedSeq.empty)),
TableMapRows(_, MakeStruct(FastSeq("a" -> I32(0)))),
TableRename(_, Map.empty, Map.empty),
).map { wrap =>
Array(wrap(tir), wrap(tir), true, "")
Expand Down