Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[benchmark] Benchmarks on Ubuntu 22.04 #13880

Merged
merged 9 commits into from
Oct 25, 2023

Conversation

ehigham
Copy link
Member

@ehigham ehigham commented Oct 20, 2023

benchmark make targets are now made directly through the make targets in benchmark/Makefile. Previous targets in hail/Makefile have been deleted.
To submit benchmarks in batch from the root directory, use

$ BENCHMARK_LABEL=label NAMESPACE=default BENCHMARK_PROJECT=your-google-project make -C benchmark submit

The benchmark docker image is now based of hail-ubuntu with a minimal set of requirements installed on top.
The hail wheel is added after the benchmark wheel in attempt to optimise build times for changes to hail code.

Update requirements and Dockerfile reflecting new base image
hail/python/dev/requirements.txt Show resolved Hide resolved
benchmark/Dockerfile Outdated Show resolved Hide resolved
benchmark/Dockerfile Outdated Show resolved Hide resolved
@daniel-goldstein daniel-goldstein self-assigned this Oct 25, 2023
@danking danking merged commit b90cdd1 into hail-is:main Oct 25, 2023
7 of 8 checks passed
@ehigham ehigham deleted the ehigham/benchmark-ubuntu-22.04 branch October 25, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants