Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[query] no unnecessary object allocations in RegionMemory.allocate #13794

Merged
merged 2 commits into from
Oct 17, 2023
Merged

[query] no unnecessary object allocations in RegionMemory.allocate #13794

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a66bfe
[query] no unnecessary object allocations in RegionMemory.allocate
Oct 11, 2023
d4829aa
admonition
danking Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion hail/src/main/scala/is/hail/annotations/RegionMemory.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ final class RegionMemory(pool: RegionPool) extends AutoCloseable {
def getCurrentBlock(): Long = currentBlock

private def allocateBigChunk(size: Long): Long = {
val (chunkPointer, chunkSize) = pool.getChunk(size)
val ret = pool.getChunk(size)
val chunkPointer = ret._1 // Match expressions allocate https://github.com/hail-is/hail/pull/13794
val chunkSize = ret._2
bigChunks.add(chunkPointer)
totalChunkMemory += chunkSize
chunkPointer
Expand Down