Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qob] prevent race to write to log file #13729

Merged
merged 1 commit into from
Sep 27, 2023
Merged

[qob] prevent race to write to log file #13729

merged 1 commit into from
Sep 27, 2023

Commits on Sep 27, 2023

  1. [qob] prevent race to write to log file 

    This finally block is currently located after `gather.take()` but *before* we cancel (aka shutdown)
all threads. As a result, it is possible for us to shudown the logging (thus flushing, closing,
and destorying old appenders) then restart logging (thus opening the file in overwrite mode) and
blow away whatever was there.

I have verified in my namespace across 10s of thosuands of JVM Jobs that this never blows away the
log.
    Dan King committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    c383c91 View commit details
    Browse the repository at this point in the history