-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[devbin] Local UI development proxy server #13632
Conversation
6c3418d
to
234c0de
Compare
@iris-garden bump |
@iris-garden bump. It's a bit tedious to keep resolving the requirements conflicts |
WIP until I get things merged |
@daniel-goldstein sorry for the slow review turnaround! the code looks good to me, and i'll try it out tomorrow morning to make sure i don't have any additional feedback. thanks! |
to be included in the dev docs: the devserver uses the whatever service you're trying to hack on the UI of needs to be |
This adds a script that runs an
aiohttp
server on localhost that by default proxies all requests to whatever batch namespacehailctl
is pointed to but serves static assets and renders all HTML locally. This allows for local editing of HTML / CSS / SCSS files.To run, this branch needs to be deployed in the relevant namespace (to pick up the changes to
web_common.py
), and you need to have thesass
CLI installed (brew install sass/sass/sass
). Then run in a separate terminalmake devserver SERVICE=batch
and open uplocalhost:8000
. If you want to supply fake data instead of proxying an endpoint to the k8s deployment of the service, you can override that endpoint indev_proxy.py
.If this looks good, I'll add the above instructions to the dev docs.
Resolves #13629