-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qob][batch] do not list all jobs on failure (plus: types!) #13500
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8166e43
[qob][batch] do not list all jobs on failure (plus: types!)
8b1ff3b
rebase cruft
4765598
add v1
b0bd3b5
mispelling
16649c7
use query string isntead of client-side filtering
902ac13
match versioning in URLs
c86c4b9
also fix front_end.py
0418da4
Merge remote-tracking branch 'hi/main' into sb-should-not-list-all-jobs
eec7cb9
sort import blocks
48e8a1d
Merge remote-tracking branch 'hi/main' into sb-should-not-list-all-jobs
02295e6
cleanup merge conflict issues
ffdcfad
cast away types when creating UI elements
629c3be
sort
3b5286a
Merge remote-tracking branch 'hi/main' into sb-should-not-list-all-jobs
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
from typing import TypedDict, Literal, Optional, List, Any, Dict | ||
from typing_extensions import NotRequired | ||
|
||
|
||
class CostBreakdownEntry(TypedDict): | ||
resource: str | ||
cost: float | ||
|
||
|
||
class GetJobResponseV1Alpha(TypedDict): | ||
batch_id: int | ||
job_id: int | ||
name: Optional[str] | ||
user: str | ||
billing_project: str | ||
state: Literal['Pending', 'Ready', 'Creating', 'Running', 'Failed', 'Cancelled', 'Error', 'Success'] | ||
exit_code: Optional[int] | ||
duration: Optional[int] | ||
cost: Optional[float] | ||
msec_mcpu: int | ||
cost_breakdown: List[CostBreakdownEntry] | ||
status: Optional[Dict[str, Any]] | ||
spec: Optional[Dict[str, Any]] | ||
attributes: NotRequired[Dict[str, str]] | ||
|
||
|
||
class JobListEntryV1Alpha(TypedDict): | ||
batch_id: int | ||
job_id: int | ||
name: Optional[str] | ||
user: str | ||
billing_project: str | ||
state: Literal['Pending', 'Ready', 'Creating', 'Running', 'Failed', 'Cancelled', 'Error', 'Success'] | ||
exit_code: Optional[int] | ||
duration: Optional[int] | ||
cost: Optional[float] | ||
msec_mcpu: int | ||
cost_breakdown: List[CostBreakdownEntry] | ||
|
||
|
||
class GetJobsResponseV1Alpha(TypedDict): | ||
jobs: List[JobListEntryV1Alpha] | ||
last_job_id: NotRequired[int] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're missing the
V1Alpha
here.