[ci] Remove unnecessary worker-deploy-config secret #13343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-goldstein
force-pushed
the
no-longer-need-worker-deploy-config
branch
from
604974e
to
73be1bd
Compare
jigold
previously requested changes
Aug 1, 2023
| @@ -3551,10 +3501,6 @@ steps: | |||
| namespace: | |||
| valueFrom: default_ns.name | |||
| mountPath: /user-tokens | |||
| - name: worker-deploy-config | |||
There was a problem hiding this comment.
Do you need to set HAIL_DEFAULT_NAMESPACE for this job or was the secret not necessary?
There was a problem hiding this comment.
The namespace is already specified in the command: hailctl curl {{ default_ns.name }}, so only the other parts of the deploy config (domain and location) were necessary, but those are now provided by the worker and don't change.
jigold
approved these changes
Aug 2, 2023
daniel-goldstein
force-pushed
the
no-longer-need-worker-deploy-config
branch
from
73be1bd
to
6b5858d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #13211, all jobs by default have a deploy config mounted into the container. The
worker-deploy-configsecret is no longer necessary, so long as we properly configure the namespace that CI jobs need to talk to.