Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deploy] Add WHEEL to environment for assert_pypi_has_room.py #13176

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

daniel-goldstein
Copy link
Contributor

@daniel-goldstein daniel-goldstein commented Jun 13, 2023

WHEEL needs to be visible in the subprocess environment for assert_pypi_has_room.py

jigold
jigold previously requested changes Jun 13, 2023
Copy link
Contributor

@jigold jigold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to double check WHEEL_FOR_AZURE isn't relevant here.

@daniel-goldstein daniel-goldstein dismissed jigold’s stale review June 13, 2023 13:13

No, WHEEL_FOR_AZURE is a wheel for hdinsight that we stuff into a bucket, WHEEL is the wheel that gets uploaded to PYPI and is the one relevant for the assert_pypi_has_room.py script.

@danking danking merged commit 3e1a740 into hail-is:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants