More parallelism timeouts strict local backend heap size #13128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trict-local-backend-heap-size
|
This now also includes #13123 |
added 2 commits
May 31, 2023 17:13
daniel-goldstein
approved these changes
May 31, 2023
danking
commented
May 31, 2023
| @@ -1941,7 +1941,7 @@ def unfilter_entries(self): | |||
| entry_ir = hl.if_else( | |||
| hl.is_defined(self.entry), | |||
| self.entry, | |||
| hl.literal(hl.Struct(**{k: hl.missing(v.dtype) for k, v in self.entry.items()})))._ir | |||
| hl.struct(**{k: hl.missing(v.dtype) for k, v in self.entry.items()}))._ir | |||
There was a problem hiding this comment.
this avoids an eval just to get None for the missing (which is the converted back to a missing IR)
danking
commented
May 31, 2023
| t = t.key_by(locus=hl.locus('1', t.idx + 1)) | ||
| t = t.annotate(annotation=hl.str(t.idx)) | ||
| t = hl.utils.genomic_range_table(10) | ||
| t = t.annotate(annotation=hl.str(t.locus.position - 1)) |
There was a problem hiding this comment.
this avoids a useless shuffle
danking
commented
May 31, 2023
| @@ -38,19 +39,6 @@ class VCFTests(unittest.TestCase): | |||
| def test_info_char(self): | |||
| self.assertEqual(hl.import_vcf(resource('infochar.vcf')).count_rows(), 1) | |||
|
|
|||
| def test_import_export_same(self): | |||
There was a problem hiding this comment.
moved outside of the unittest class so that I can use pytest parameterization.
added 17 commits
May 31, 2023 19:53
illusional
added a commit
to populationgenomics/hail
that referenced
this pull request
Jun 14, 2023
Corrected in hail-is#13128, but not sure why I selected the wrong bit of the merge.
illusional
added a commit
to populationgenomics/hail
that referenced
this pull request
Jun 14, 2023
Corrected in hail-is#13128, but not sure why I selected the wrong bit of the merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.