[services] reliably retry all requests #13029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`request_retry_transient_errors` is a charlatan. It does not retry errors that occur in reading the response body. I eliminated it in favor of the tried and true `retry_transient_errors` and some new helper methods that initiate the request *and* read the response.
danking
commented
May 10, 2023
| session, | ||
| 'GET', | ||
| resp_json = await retry_transient_errors( | ||
| session.get_return_json, |
There was a problem hiding this comment.
I was also thinking about calling this get_read_json. Thoughts? I'm trying to convey a distinction between this method and the one which returns a body reading handle.
|
An example of an error that wasn't retried properly: |
daniel-goldstein
previously requested changes
May 10, 2023
There was a problem hiding this comment.
I don't really take issue with these names. What I care most about here is that those methods properly use the response as a context manager, which I feel is easy to miss and a footgun, so I'm in favor of more convenience functions like these that return the end data type (like a Dict) instead of a httpx.ClientResponse
| @@ -101,10 +101,11 @@ async def async_copy_paste_login(copy_paste_token: str, namespace: Optional[str] | |||
| raise_for_status=True, | |||
| timeout=aiohttp.ClientTimeout(total=5), | |||
| headers=headers) as session: | |||
| async with await request_retry_transient_errors( | |||
There was a problem hiding this comment.
This should be an httpx.ClientSession
There was a problem hiding this comment.
Great catch. I removed another case of aiohttp.ClientSession from job.py as well. It now only appears in httpx.py.
daniel-goldstein
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request_retry_transient_errorsis a charlatan. It does not retry errors that occur in reading the response body. I eliminated it in favor of the tried and trueretry_transient_errorsand some new helper methods that initiate the request and read the response.