[all][query] update to Python3.8 which allows for numpy 1.24.2 #12908
Conversation
|
Sorry if this is jumping the gun, but can you add a reference in the docs to numpy's versioning policy and say that we follow that now? |
|
Haha, I had intentionally not assigned you until I sorted what I anticipate is a long tail of issues. Nonetheless, updated. |
danking
force-pushed
the
python3.8-numpy-1.24.2
branch
from
2e92627
to
e45f717
Compare
| ./generate-linux-pip-lockfile.sh hail/python | ||
|
|
||
| hail/python/dev/pinned-requirements.txt: hail/python/dev/requirements.txt hail/python/pinned-requirements.txt | ||
| hail/python/dev/pinned-requirements.txt: hail/python/pinned-requirements.txt hail/python/dev/requirements.txt |
There was a problem hiding this comment.
I flipped these so that the pinned-requirements.txt dependencies always come first
| ./generate-linux-pip-lockfile.sh hail/python/dev | ||
|
|
||
| gear/pinned-requirements.txt: hail/python/hailtop/pinned-requirements.txt gear/requirements.txt | ||
| gear/pinned-requirements.txt: hail/python/pinned-requirements.txt hail/python/dev/pinned-requirements.txt gear/requirements.txt |
There was a problem hiding this comment.
gear/pinned-requirements.txt has a -c dependency on python/pinned-requirements.txt and python/dev/pinned-requirements.txt. It was missing both of those dependencies in the makefile which lead me to have incompatible versions between gear/pinned-requirements.txt and python/dev/pinned-requirements.txt which lead to issues when both of those were -c required in auth.
|
This would indicate that we're already in 3.9+ territory. Maybe a lot to drop two python versions at once, do you have any thoughts on when we should also drop 3.8? |
|
Great point. I'm inclined to at least do separate PRs since this one is, as expected, becoming a bit of a compatibility nightmare. |
danking
force-pushed
the
python3.8-numpy-1.24.2
branch
from
be7f6e9
to
6916292
Compare
Bumps [numpy](https://github.com/numpy/numpy) from 1.21.6 to 1.24.2. - [Release notes](https://github.com/numpy/numpy/releases) - [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst) - [Commits](numpy/numpy@v1.21.6...v1.24.2) --- updated-dependencies: - dependency-name: numpy dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
CHANGELOG: Hail no longer officially supports Python 3.7.
danking
force-pushed
the
python3.8-numpy-1.24.2
branch
from
6916292
to
e141024
Compare
|
I'm gonna submit a new PR which subsumes this and #12927 because they're both entangled in a bunch of the same issues and its increasingly apparent that I need them together to pass all the tests. |
…es to req generation (#12929) CHANGELOG: Hail no longer officially supports Python 3.7. Combines #12927 and #12908. Many changes. All seem to be necessary together. --- I fixed any new mypy errors or deprecation warnings. I also cleaned up plots.py (which isn't CI'd by mypy) because I was in there and it was a mess. I unified all our pip-tools versions. Require pandas 2 now. That requires Bokeh 3.x.x. Fix the pinned-requirements.txt dependencies so they reflect the actual necessary runtime harmony. Upgraded Sphinx. The method names lose their fixed-width styling but I think it looks fine. Version policy added. Updating everything means Jinja2 can jump to the latest version too. Numpy deprecated some of its types, using `_` gets rid of the warning. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
CHANGELOG: Hail no longer officially supports Python 3.7.