[query] fix & improve pprint for hl.Struct #12901
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG:
hl.Struct
now has a correct and useful implementation of pprint.For structs with keys that were not identifiers, we produced incorrect
repr
output. Forpprint
, we justpprint
'ed a dictionary (so you cannot even tell that the object was anhl.Struct
). This PR:hl.Struct.__str__
to use the kwargs or dictionary representation based on whether the keys are Python identifiers.StructPrettyPrinter
to first try torepr
the struct (this is what the default pretty printer does)StructPrettyPrinter
to properly pretty print a struct as anhl.Struct
preferring the kwarg representation when appropriate._same
to use pretty printing when showing differing records.