Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[batch] Clean up environment variables for easier local execution of batch tests #12862

Merged
merged 4 commits into from
Apr 11, 2023

Conversation

daniel-goldstein
Copy link
Contributor

Trying to make it more ergonomic to simply do python3 -m pytest batch/test/test_batch.py::test_job (now works without any extra environment variables or configuration).

This involved the following changes:

  • Deleted of some env vars that are no longer used / can be easily consolidated into existing ones
  • Gave defaults to those testing env variables for which there are reasonable defaults. E.g. DOCKER_ROOT_IMAGE and HAIL_GENETICS_HAIL_IMAGE.
  • Pushed other environment variables for which there are not reasonable defaults into the tests that need them. If you run a test that requires HAIL_CLOUD, you'll still get an error that that env variable is unset and you should set it. But, if you just want to run a single test that doesn't need HAIL_CLOUD it won't get in the way.

Copy link
Contributor

@danking danking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@danking danking merged commit 92e2699 into hail-is:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants