-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[batch] Profile more services not just batch-driver #12681
[batch] Profile more services not just batch-driver #12681
Conversation
gear/gear/profiling.py
Outdated
verbose=3, | ||
) | ||
|
||
def ignore_failed_to_collect_and_upload_profile(record): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this block need to be indented to the left by 1 tab?
gear/gear/profiling.py
Outdated
import googlecloudprofiler | ||
|
||
HAIL_SHA = os.environ['HAIL_SHA'] | ||
HAIL_SHOULD_PROFILE = os.environ.get('HAIL_SHOULD_PROFILE', False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to cast this to a boolean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to an in
check, since we only ever include that environment variable when we want to profile.
No description provided.