Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[batch] Fix google-cloud-storage version requirement #12677

Conversation

lgruen
Copy link
Contributor

@lgruen lgruen commented Feb 10, 2023

>= is not compatible with wildcards:

cd build/deploy; rm -rf build; python3 setup.py -q sdist bdist_wheel
/usr/local/lib/python3.7/dist-packages/setuptools/installer.py:30: SetuptoolsDeprecationWarning: setuptools.installer is deprecated. Requirements should be satisfied by a PEP 517 installer.
  SetuptoolsDeprecationWarning,
error in hail setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; Expected end or semicolon (after version specifier)
    google-cloud-storage>=1.25.*
                        ~~~~~~^
make: *** [Makefile:248: build/deploy/dist/hail-0.2.109-py3-none-any.whl] Error 1

I'm not sure why this hasn't shown up before, but we couldn't deploy 0.2.109 without this fix.

#assign services

@daniel-goldstein daniel-goldstein self-assigned this Feb 10, 2023
@lgruen lgruen changed the title Fix google-cloud-storage version requirement [batch] Fix google-cloud-storage version requirement Feb 10, 2023
Copy link
Contributor

@daniel-goldstein daniel-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting… I wonder if this has to do with a distutils version difference? I've not run into that error when installing but this looks like a correct change nonetheless.

@danking danking merged commit 7d84db0 into hail-is:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants