Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[batch] Mitigate too many resources with same prices #12654

Merged
merged 3 commits into from
Feb 14, 2023

Conversation

jigold
Copy link
Contributor

@jigold jigold commented Feb 3, 2023

I left out the cloud specific check and just make it so we don't have this problem again on any cloud.

danking
danking previously requested changes Feb 6, 2023
Copy link
Contributor

@danking danking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's check for equality

@jigold
Copy link
Contributor Author

jigold commented Feb 10, 2023

I'm putting the WIP tag for Monday. I changed the code slightly from before. I checked and the test PR driver logs were at least clean.

Copy link
Contributor

@danking danking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jigold
Copy link
Contributor Author

jigold commented Feb 13, 2023

I forgot there was a WIP on here. Will take it off tomorrow morning.

@jigold jigold removed the WIP label Feb 14, 2023
@danking danking merged commit d03121f into hail-is:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants