Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service-base] fix libsass by downgrading google-cloud-profiler #12544

Merged
merged 3 commits into from
Dec 14, 2022

Conversation

danking
Copy link
Contributor

@danking danking commented Dec 7, 2022

No description provided.

google-cloud-profiler==4.0.0
# https://github.com/sass/libsass-python/issues/413
google-cloud-profiler<4.0.0
protobuf<=3.20.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protobuf is already in the docker pinned requirements as a transitive dependency, so I'm guessing this will downgrade it. That should probably be pinned in docker/requirements.txt instead.

@daniel-goldstein
Copy link
Contributor

@danking I'd apply this patch. Not sure why we install those dependencies in the auth dockerfile, they're already in the docker requirements:

diff --git a/auth/Dockerfile b/auth/Dockerfile
index 0c2bfa4dad..a94928c697 100644
--- a/auth/Dockerfile
+++ b/auth/Dockerfile
@@ -1,9 +1,5 @@
 FROM {{ service_base_image.image }}
 
-RUN hail-pip-install \
-      google-auth-oauthlib==0.4.6 \
-      google-auth==1.25.0
-
 COPY auth/setup.py auth/MANIFEST.in /auth/
 COPY auth/auth /auth/auth/
 RUN hail-pip-install /auth && rm -rf /auth

@danking danking merged commit fa77bce into hail-is:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants