Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qob] Invalidate batch cache on error #12519

Merged
merged 1 commit into from
Dec 1, 2022
Merged

[qob] Invalidate batch cache on error #12519

merged 1 commit into from
Dec 1, 2022

Conversation

jigold
Copy link
Contributor

@jigold jigold commented Nov 30, 2022

Not sure this is the right fix, but I believe we can't update a batch once it's been cancelled still.

@jigold
Copy link
Contributor Author

jigold commented Nov 30, 2022

Maybe this change isn't needed. Can we cancel a batch multiple times now?

daniel-goldstein
daniel-goldstein approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@daniel-goldstein daniel-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot. I don't think you can do anything with a batch at the moment once it's been cancelled, I think this is the right change for the time-being.

@danking danking merged commit 1e1ef36 into hail-is:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-goldstein daniel-goldstein daniel-goldstein approved these changes

Assignees

@daniel-goldstein daniel-goldstein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jigold @daniel-goldstein @danking