Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[query] rework flags and fix QoB flags #12423

Merged
merged 1 commit into from
Feb 18, 2023
Merged

[query] rework flags and fix QoB flags #12423

merged 1 commit into from
Feb 18, 2023

Commits on Feb 17, 2023

  1. [query] rework flags and fix QoB flags 

    Flags now use the same user configuration machinery we use for Batch and QoB. I am not certain
this is the right choice. Feedback very welcome. The configuration_of function lets us uniformly
treat any configuration by checking, in order: explicit argument, envvar, config file, or a
fallback.

I added a bit of code to allow us to support the envvars which do not conform to the new envvar
scheme.

I also removed a few flags that are no longer used.

I kind of think these flags should actually be under a new section like "query_compiler" or
something.

@tpoterba, thoughts?
    Daniel King committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    6fc6900 View commit details
    Browse the repository at this point in the history