Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[batch] Remove lint errors from test_batch and test_accounts #12147

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

daniel-goldstein
Copy link
Contributor

@daniel-goldstein daniel-goldstein commented Aug 31, 2022

Basically all naming, rids these test files of linting errors. We do a lot of reassigning a BatchBuilder variable to a Batch and so I consolidated around bb and b. A couple instances where I remove debug_info from an assert statement is because the associated Batch object would not exist, since that assert is triggered by an error that's raised before the Batch object is created.

Copy link
Contributor

@danking danking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@danking danking merged commit 22a0d3d into hail-is:main Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants