[query] Table.write_many #12091
Merged
[query] Table.write_many #12091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 17, 2022 15:39
CHANGELOG: Teach `Table` to `write_many`, which writes one table per provided field.
|
It occurs to me you should reject this until I write a non-lowered execution path since we can't assume a lowered execution is possible yet. |
|
bump @patrick-schultz, I've another branch that depends on this. |
|
@tpoterba I forget exactly the conclusion from our last conversation about whether or not new functionality should implement a non-lowered path. This PR's new reader raises an exception if you try to interpret it. |
|
@danking Sorry, from your last comment I thought you wanted to wait on a non-lowered implementation. I looked over this last week and everything looked good. I'll give it a last pass now. |
patrick-schultz
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG: Teach
Tabletowrite_many, which writes one table per provided field.