-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MakeNDArray OOM on stream data #14559
Comments
daniel-goldstein
added
bug
and removed
needs-triage
A brand new issue that needs triaging.
labels
Jun 3, 2024
Hard to pinpoint what's the true cause of this bug.
hl.bind(covmat, hl.nd.array).show() the program successfully completes |
ehigham
added a commit
to ehigham/hail
that referenced
this issue
Jun 5, 2024
Fixes: hail-is#14559 `hl.nd.array`s constructed from stream pipelines can cause out of memory exceptions owing to a limitation in the python CSE algorithm that does not eliminate partially redundant expressions if if-expressions. Explicitly `let`-binding the input collection prevents it from being evaluated twice: once for the flattened data stream and once for the original shape.
ehigham
added a commit
to ehigham/hail
that referenced
this issue
Jun 5, 2024
Fixes: hail-is#14559 hl.nd.arrays constructed from stream pipelines can cause out of memory exceptions owing to a limitation in the python CSE algorithm that does not eliminate partially redundant expressions if if-expressions. Explicitly let-binding the input collection prevents it from being evaluated twice: once for the flattened data stream and once for the original shape.
hail-ci-robot
pushed a commit
that referenced
this issue
Jun 6, 2024
Fixes: #14559 `hl.nd.array`s constructed from stream pipelines can cause out of memory exceptions owing to a limitation in the python CSE algorithm that does not eliminate partially redundant expressions in if-expressions. Explicitly `let`-binding the input collection prevents it from being evaluated twice: once for the flattened data stream and once for the original shape.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
From: https://discuss.hail.is/t/connectionerror-after-mt-aggregate-cols-hl-agg-collect-and-hl-nd-array-in-linear-skat/3839
The following code snippet blows up from OOM. Interestingly, I can only reproduce for
_localize=False
, indicating we have an problem with ourEmit
rule forMakeNDArray
for data IRs of typeTStream
.Version
0.2.130
Relevant log output
No response
The text was updated successfully, but these errors were encountered: