Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] test_hail_in_notebook is not idempotent #13994

Closed
danking opened this issue Nov 9, 2023 · 0 comments · Fixed by #13999
Closed

[query] test_hail_in_notebook is not idempotent #13994

danking opened this issue Nov 9, 2023 · 0 comments · Fixed by #13999
Assignees

Comments

@danking
Copy link
Contributor

danking commented Nov 9, 2023

What happened?

https://batch.hail.is/batches/8083756/jobs/72

test_hail_in_notebook just executed jupyter on test_hail_in_notebook.ipynb. The notebook contains one cell:

import hail as hl
import os
hl.utils.range_table(1).write(f'{os.environ["HAIL_TEST_STORAGE_URI"]}/test_hail_in_notebook.ht')
from helpers import resource
hl.read_table(resource('backward_compatability/1.7.0/table/9.ht')).count()

This is not idempotent because HAIL_TEST_STORAGE_URI is randomly generated once per job not once per attempt. In particular, the job specification itself has this as an environment variable. In the this PR test job, the test job gets preempted and rescheduled. Upon rescheduling, the hail table already exists, causing the test to fail.

The fix is simple: add a random string to the written Hail table file.

Version

0.2.126

Relevant log output

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants