Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hailtop.batch errs when a batch of zero jobs is submitted and waited on #12924

Closed
danking opened this issue Apr 24, 2023 · 1 comment · Fixed by #12953
Closed

hailtop.batch errs when a batch of zero jobs is submitted and waited on #12924

danking opened this issue Apr 24, 2023 · 1 comment · Fixed by #12953
Assignees
Labels

Comments

@danking
Copy link
Contributor

danking commented Apr 24, 2023

What happened?

Reported by Wenhan: https://hail.zulipchat.com/#narrow/stream/223457-Hail-Batch-support/topic/ValueError.3A.20min.28.29.20arg.20is.20an.20empty.20sequence/near/352319161

  File "/usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/hailtop/batch/backend.py", line 791, in _async_run
    starting_job_id = min(j._client_job.job_id for j in unsubmitted_jobs)

I suspect we do not handle waiting on an empty batch / batch update correctly. We should probably bail out immediately from the wait when there are no jobs on which to wait.

Version

batch

Relevant log output

No response

@danking danking changed the title Hail Batch hailtop.batch errs when a batch of zero jobs is submitted and waited on Apr 24, 2023
@daniel-goldstein
Copy link
Contributor

Looks like we emit a warning here, but ya we should probably bail out before we get to this line because starting_job_id makes no sense if there are no jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants