Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

‘locus’ (type ‘locus<any>’) #12844

Closed
skr3178 opened this issue Apr 4, 2023 · 8 comments · Fixed by #12851
Closed

‘locus’ (type ‘locus<any>’) #12844

skr3178 opened this issue Apr 4, 2023 · 8 comments · Fixed by #12851

Comments

@skr3178
Copy link

skr3178 commented Apr 4, 2023

What happened?

ValueError: Method ‘variant_qc’ requires row key to be two fields ‘locus’ (type ‘locus’) and ‘alleles’ (type ‘array’)
Found:
‘locus’: struct{contig: str, position: int32}
‘alleles’: array

image

I am aware the standard locus column is a format
image
whereas the format I have is
image

Version

version 0.2.112-31ceff2fb5fd

Relevant log output

No response

@danking
Copy link
Contributor

danking commented Apr 5, 2023

@tpoterba this seems overly restrictive no?

@tpoterba
Copy link
Contributor

tpoterba commented Apr 5, 2023

Yeah, we could relax this to just require the alleles.

danking pushed a commit to danking/hail that referenced this issue Apr 6, 2023
CHANGELOG: `hl.variant_qc` no longer requires a `locus` field.

Fixes hail-is#12844.
@danking
Copy link
Contributor

danking commented Apr 6, 2023

Thanks for the report!

danking added a commit that referenced this issue Apr 6, 2023
CHANGELOG: `hl.variant_qc` no longer requires a `locus` field.

Fixes #12844.
@skr3178
Copy link
Author

skr3178 commented Apr 10, 2023

thank you for these changes.
I am facing trouble in installing this branch of the package.

i tried

pip install git+https://github.com/danking/hail.git@relax-variant-qc

git clone https://github.com/danking/hail.git --branch relax-variant-qc --single-branch
cd hail
pip install .

@danking
Copy link
Contributor

danking commented Apr 10, 2023

I can’t help you without an error message or description of what didn’t work. I recommend waiting for the next release which should come out today.

@skr3178
Copy link
Author

skr3178 commented Apr 10, 2023

pip install -e .
Defaulting to user installation because normal site-packages is not writeable
Obtaining file:///home/skr/hail2/hail
Installing build dependencies ... done
Checking if build backend supports build_editable ... done
Getting requirements to build editable ... error
error: subprocess-exited-with-error

× Getting requirements to build editable did not run successfully.
│ exit code: 1
╰─> [14 lines of output]
error: Multiple top-level packages discovered in a flat-layout: ['tls', 'gear', 'hail', 'auth', 'blog', 'infra', 'batch', 'query', 'docker', 'memory', 'devbin', 'gateway', 'website', 'grafana', 'notebook', 'graphics', 'datasets', 'monitoring', 'web_common', 'prometheus', 'letsencrypt'].

  To avoid accidental inclusion of unwanted files or directories,
  setuptools will not proceed with this build.
  
  If you are trying to create a single distribution with multiple packages
  on purpose, you should not rely on automatic discovery.
  Instead, consider the following options:
  
  1. set up custom discovery (`find` directive with `include` or `exclude`)
  2. use a `src-layout`
  3. explicitly set `py_modules` or `packages` with a list of names
  
  To find more information, look for "package discovery" on setuptools docs.
  [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build editable did not run successfully.
│ exit code: 1
╰─> See above for output.

@danking
Copy link
Contributor

danking commented Apr 10, 2023

The Hail python package is not a pure-Python package. Installing it from source requires building a JAR file. We have instructions here, but I recommend waiting for the next PyPI release.

@skr3178
Copy link
Author

skr3178 commented Apr 10, 2023

Ok I will for the new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants