Skip to content

Commit

Permalink
[qob] fix ServiceBackend.get_flags
Browse files Browse the repository at this point in the history
I just plainly implemented this wrong the first time.
  • Loading branch information
Daniel King committed Oct 12, 2022
1 parent f12a5f0 commit 669efef
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion hail/python/hail/backend/service_backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,7 @@ def set_flags(self, **flags: str):
self.flags.update(flags)

def get_flags(self, *flags) -> Mapping[str, str]:
return frozendict(self.flags)
return {flag: self.flags[flag] for flag in flags}

@property
def requires_lowering(self):
Expand Down
4 changes: 4 additions & 0 deletions hail/python/test/hail/test_context.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,7 @@ def test_top_level_functions_are_do_not_error(self):

def test_tmpdir_runs(self):
isinstance(hl.tmp_dir(), str)

def test_get_flags(self):
assert hl._get_flags() == set()
assert list(hl._get_flags('use_new_shuffle')) == 'use_new_shuffle'

0 comments on commit 669efef

Please sign in to comment.