Skip to content

Commit

Permalink
automatic changes
Browse files Browse the repository at this point in the history
  • Loading branch information
iris-garden committed Jan 9, 2024
1 parent b822bcc commit 44d9c7e
Show file tree
Hide file tree
Showing 163 changed files with 2,432 additions and 2,708 deletions.
36 changes: 19 additions & 17 deletions auth/auth/auth.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,10 @@ async def _insert(tx):
return False

await tx.execute_insertone(
'''
"""
INSERT INTO users (state, username, login_id, is_developer, is_service_account, hail_identity, hail_credentials_secret_name)
VALUES (%s, %s, %s, %s, %s, %s, %s);
''',
""",
(
'creating',
username,
Expand Down Expand Up @@ -482,9 +482,11 @@ async def rest_login(request: web.Request) -> web.Response:
flow_data['callback_uri'] = callback_uri

# keeping authorization_url and state for backwards compatibility
return json_response(
{'flow': flow_data, 'authorization_url': flow_data['authorization_url'], 'state': flow_data['state']}
)
return json_response({
'flow': flow_data,
'authorization_url': flow_data['authorization_url'],
'state': flow_data['state'],
})


@routes.get('/api/v1alpha/oauth2-client')
Expand All @@ -511,10 +513,10 @@ async def post_create_role(request: web.Request, _) -> NoReturn:
name = str(post['name'])

role_id = await db.execute_insertone(
'''
"""
INSERT INTO `roles` (`name`)
VALUES (%s);
''',
""",
(name),
)

Expand Down Expand Up @@ -564,10 +566,10 @@ async def rest_get_users(request: web.Request, userdata: UserData) -> web.Respon
raise web.HTTPUnauthorized()

db = request.app[AppKeys.DB]
_query = '''
_query = """
SELECT id, username, login_id, state, is_developer, is_service_account, hail_identity
FROM users;
'''
"""
users = [x async for x in db.select_and_fetchall(_query)]
return json_response(users)

Expand All @@ -579,10 +581,10 @@ async def rest_get_user(request: web.Request, _) -> web.Response:
username = request.match_info['user']

user = await db.select_and_fetchone(
'''
"""
SELECT id, username, login_id, state, is_developer, is_service_account, hail_identity FROM users
WHERE username = %s;
''',
""",
(username,),
)
if user is None:
Expand All @@ -599,11 +601,11 @@ async def _delete_user(db: Database, username: str, id: Optional[str]):
where_args.append(id)

n_rows = await db.execute_update(
f'''
f"""
UPDATE users
SET state = 'deleting'
WHERE {' AND '.join(where_conditions)};
''',
""",
where_args,
)

Expand Down Expand Up @@ -743,11 +745,11 @@ async def get_userinfo_from_login_id_or_hail_identity_id(
users = [
x
async for x in db.select_and_fetchall(
'''
"""
SELECT users.*
FROM users
WHERE (users.login_id = %s OR users.hail_identity_uid = %s) AND users.state = 'active'
''',
""",
(login_id_or_hail_idenity_uid, login_id_or_hail_idenity_uid),
)
]
Expand All @@ -767,12 +769,12 @@ async def get_userinfo_from_hail_session_id(request: web.Request, session_id: st
users = [
x
async for x in db.select_and_fetchall(
'''
"""
SELECT users.*
FROM users
INNER JOIN sessions ON users.id = sessions.user_id
WHERE users.state = 'active' AND sessions.session_id = %s AND (ISNULL(sessions.max_age_secs) OR (NOW() < TIMESTAMPADD(SECOND, sessions.max_age_secs, sessions.created)));
''',
""",
session_id,
'get_userinfo',
)
Expand Down
16 changes: 8 additions & 8 deletions auth/auth/driver/driver.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,10 @@ async def delete(self):
return

await self.db.just_execute(
'''
"""
DELETE FROM sessions
WHERE session_id = %s;
''',
""",
(self.session_id,),
)
self.session_id = None
Expand Down Expand Up @@ -430,11 +430,11 @@ async def _create_user(app, user, skip_trial_bp, cleanup):
updates['trial_bp_name'] = billing_project_name

n_rows = await db.execute_update(
f'''
f"""
UPDATE users
SET {', '.join([f'{k} = %({k})s' for k in updates])}
WHERE id = %(id)s AND state = 'creating';
''',
""",
{'id': user['id'], **updates},
)
if n_rows != 1:
Expand Down Expand Up @@ -502,10 +502,10 @@ async def delete_user(app, user):
await bp.delete()

await db.just_execute(
'''
"""
DELETE FROM sessions WHERE user_id = %s;
UPDATE users SET state = 'deleted' WHERE id = %s;
''',
""",
(user['id'], user['id']),
)

Expand All @@ -523,11 +523,11 @@ async def resolve_identity_uid(app, hail_identity):
hail_identity_uid = await sp.get_service_principal_object_id()

await db.just_execute(
'''
"""
UPDATE users
SET hail_identity_uid = %s
WHERE hail_identity = %s
''',
""",
(hail_identity_uid, hail_identity),
)

Expand Down
4 changes: 2 additions & 2 deletions batch/batch/batch.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,11 @@ async def cancel_batch_in_db(db, batch_id):
@transaction(db)
async def cancel(tx):
record = await tx.execute_and_fetchone(
'''
"""
SELECT `state` FROM batches
WHERE id = %s AND NOT deleted
FOR UPDATE;
''',
""",
(batch_id,),
)
if not record:
Expand Down
8 changes: 4 additions & 4 deletions batch/batch/cloud/azure/driver/create_instance.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def create_vm_config(

jvm_touch_command = '\n'.join(touch_commands)

startup_script = r'''#cloud-config
startup_script = r"""#cloud-config
mounts:
- [ ephemeral0, null ]
Expand Down Expand Up @@ -123,10 +123,10 @@ def create_vm_config(
runcmd:
- sh /startup.sh
'''
"""
startup_script = base64.b64encode(startup_script.encode('utf-8')).decode('utf-8')

run_script = f'''
run_script = f"""
#!/bin/bash
set -x
Expand Down Expand Up @@ -302,7 +302,7 @@ def create_vm_config(
az vm delete -g $RESOURCE_GROUP -n $NAME --yes
sleep 1
done
'''
"""

user_data = {
'run_script': run_script,
Expand Down
4 changes: 2 additions & 2 deletions batch/batch/cloud/azure/driver/driver.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ async def create(

region_args = [(r,) for r in regions]
await db.execute_many(
'''
"""
INSERT INTO regions (region) VALUES (%s)
ON DUPLICATE KEY UPDATE region = region;
''',
""",
region_args,
)

Expand Down
18 changes: 8 additions & 10 deletions batch/batch/cloud/azure/instance_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,14 @@ def create(
else:
data_disk_resource = AzureStaticSizedDiskResource.create(product_versions, 'P', data_disk_size_gb, location)

resources: List[AzureResource] = filter_none(
[
AzureVMResource.create(product_versions, machine_type, preemptible, location),
AzureStaticSizedDiskResource.create(product_versions, 'E', boot_disk_size_gb, location),
data_disk_resource,
AzureDynamicSizedDiskResource.create(product_versions, 'P', location),
AzureIPFeeResource.create(product_versions, 1024),
AzureServiceFeeResource.create(product_versions),
]
)
resources: List[AzureResource] = filter_none([
AzureVMResource.create(product_versions, machine_type, preemptible, location),
AzureStaticSizedDiskResource.create(product_versions, 'E', boot_disk_size_gb, location),
data_disk_resource,
AzureDynamicSizedDiskResource.create(product_versions, 'P', location),
AzureIPFeeResource.create(product_versions, 1024),
AzureServiceFeeResource.create(product_versions),
])

return AzureSlimInstanceConfig(
machine_type=machine_type,
Expand Down
4 changes: 2 additions & 2 deletions batch/batch/cloud/azure/worker/credentials.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@ def identity_provider_json(self):

def blobfuse_credentials(self, account: str, container: str) -> str:
# https://github.com/Azure/azure-storage-fuse
return f'''
return f"""
accountName {account}
authType SPN
servicePrincipalClientId {self.username}
servicePrincipalClientSecret {self.password}
servicePrincipalTenantId {self._credentials['tenant']}
containerName {container}
'''
"""
4 changes: 2 additions & 2 deletions batch/batch/cloud/gcp/driver/activity_logs.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,14 @@ async def process_activity_log_events_since(
project: str,
mark: str,
) -> str:
filter = f'''
filter = f"""
(logName="projects/{project}/logs/cloudaudit.googleapis.com%2Factivity" OR
logName="projects/{project}/logs/cloudaudit.googleapis.com%2Fsystem_event"
) AND
resource.type=gce_instance AND
protoPayload.resourceName:"{machine_name_prefix}" AND
timestamp >= "{mark}"
'''
"""

body = {
'resourceNames': [f'projects/{project}'],
Expand Down
22 changes: 10 additions & 12 deletions batch/batch/cloud/gcp/driver/create_instance.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,10 @@ def scheduling() -> dict:
}

if preemptible:
result.update(
{
'provisioningModel': 'SPOT',
'instanceTerminationAction': 'DELETE',
}
)
result.update({
'provisioningModel': 'SPOT',
'instanceTerminationAction': 'DELETE',
})

return result

Expand Down Expand Up @@ -129,7 +127,7 @@ def scheduling() -> dict:
'items': [
{
'key': 'startup-script',
'value': '''
'value': """
#!/bin/bash
set -x
Expand All @@ -150,11 +148,11 @@ def scheduling() -> dict:
curl -s -H "Metadata-Flavor: Google" "http://metadata.google.internal/computeMetadata/v1/instance/attributes/run_script" >./run.sh
nohup /bin/bash run.sh >run.log 2>&1 &
''',
""",
},
{
'key': 'run_script',
'value': rf'''
'value': rf"""
#!/bin/bash
set -x
Expand Down Expand Up @@ -346,18 +344,18 @@ def scheduling() -> dict:
gcloud -q compute instances delete $NAME --zone=$ZONE
sleep 1
done
''',
""",
},
{
'key': 'shutdown-script',
'value': '''
'value': """
set -x
INSTANCE_ID=$(curl -s -H "Metadata-Flavor: Google" "http://metadata.google.internal/computeMetadata/v1/instance/attributes/instance_id")
NAME=$(curl -s http://metadata.google.internal/computeMetadata/v1/instance/name -H 'Metadata-Flavor: Google')
journalctl -u docker.service > dockerd.log
''',
""",
},
{'key': 'activation_token', 'value': activation_token},
{'key': 'batch_worker_image', 'value': BATCH_WORKER_IMAGE},
Expand Down
6 changes: 3 additions & 3 deletions batch/batch/cloud/gcp/driver/driver.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ async def create(

region_args = [(region,) for region in regions]
await db.execute_many(
'''
"""
INSERT INTO regions (region) VALUES (%s)
ON DUPLICATE KEY UPDATE region = region;
''',
""",
region_args,
)

Expand Down Expand Up @@ -92,7 +92,7 @@ async def create(
inst_coll_configs.jpim_config,
task_manager,
),
*create_pools_coros
*create_pools_coros,
)

driver = GCPDriver(
Expand Down
1 change: 0 additions & 1 deletion batch/batch/cloud/gcp/worker/worker_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ async def _mount_cloudfuse(
mount_base_path_tmp: str,
config: dict,
): # pylint: disable=unused-argument

fuse_credentials_path = self._write_gcsfuse_credentials(credentials, mount_base_path_data)

bucket = config['bucket']
Expand Down
Loading

0 comments on commit 44d9c7e

Please sign in to comment.