Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the cplocn2atm namelist option to turn on/off ocean feedback to FV3 #7

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

BinLiu-NOAA
Copy link

Currently, when running coupled configurations/applications (e.g., HAFS or S2S). There is no available option to control one-way coupling to turn off the ocean model component feedback (e.g., SST) to FV3ATM.

Similar to the cplwav2atm namelist option, add a cplocn2atm namelist option to turn on/off the ocean model component feedback (e.g., SST) to the atmosphere model component. This is useful to control the one-way or two-way atmosphere-ocean coupling, as well as to configure different combinations for the atmosphere-ocean-wave coupling in HAFS and/or other applications.

…., SST) to

the atmosphere model component. It is useful to control the one-way or two-way
atmosphere-ocean coupling.
@BinLiu-NOAA
Copy link
Author

Hi @danrosen25, @ChunxiZhang-NOAA , and others, wondering if you could help to review this set of changes when you get a chance. If they look good to you, after merging back to support/HAFS branch, we will also try to create a PR to merge it back the authoritative develop branch under NOAA-EMC/fv3atm. Thanks!

@danrosen25
Copy link

The code changes look good but let me run tests after I run the new ww3 coupling tests.

Copy link

@ChunxiZhang-NOAA ChunxiZhang-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good

@BinLiu-NOAA
Copy link
Author

Merging this branch back to support/HAFS. Will create a PR to merge this capability back to NOAA-EMC/FV3atm develop branch as well.

@BinLiu-NOAA BinLiu-NOAA merged commit 5e6c519 into support/HAFS Aug 23, 2021
BijuThomas-NOAA pushed a commit that referenced this pull request Feb 3, 2025
* Update diagnose_cplFields routine to use FieldBundleWrite. Needs esmf v8.6.0

* Fixed bug in aux2d dimensions for GFS meta file.

* Pass return code from diagnose_cplFields back to caller

* Skip 'cpl_scalars' field when dumping export state

* fix fhzero for GEFS

* fix cpl_scalars (#6)

* fix issues w/ cplscalars

* error out of all 3 spatial indices are not present

* add check for scalar_id = 0

* modify for timeslices and times (#7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants