filestore: don't assume flow is TCP

Filestore can be used by UDP based protocols as well. NFSv2 is one that Suricata supports. Bug OISF#3277.
hadojae · Nov 2, 2019 · 0824b04 · 0824b04
1 parent 2a55afb
commit 0824b04
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/detect-filestore.c b/src/detect-filestore.c
@@ -209,10 +209,11 @@ static int DetectFilestorePostMatch(DetectEngineThreadCtx *det_ctx,
 #endif
     }
 
-    /* set filestore depth for stream reassembling */
-    TcpSession *ssn = (TcpSession *)p->flow->protoctx;
-    TcpSessionSetReassemblyDepth(ssn, FileReassemblyDepth());
-
+    if (p->proto == IPPROTO_TCP && p->flow->protoctx != NULL) {
+        /* set filestore depth for stream reassembling */
+        TcpSession *ssn = (TcpSession *)p->flow->protoctx;
+        TcpSessionSetReassemblyDepth(ssn, FileReassemblyDepth());
+    }
     if (p->flowflags & FLOW_PKT_TOCLIENT)
         flags |= STREAM_TOCLIENT;
     else