Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Instantiate() revert dirty state of prefab #720

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Make Instantiate() revert dirty state of prefab #720

merged 3 commits into from
Nov 12, 2024

Conversation

yellowisher
Copy link
Contributor

This fixes #662

@vercel Vercel
Copy link

vercel bot commented Nov 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vcontainer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 4:27pm

@hadashiA
Copy link
Owner

Thanks!
However, I would like to see the minimum version of Unity that has this EditorUtility API.

@yellowisher
Copy link
Contributor Author

yellowisher commented Nov 11, 2024 •
edited
Loading

Oh I missed it. Thanks as well.
It seems
EditorUtility.ClearDirty() is added at 2020.1.0f1
EditorUtility.IsDirty() is added at 2019.1.0f2

Wrapping with UNITY_2020_1_OR_NEWER would be enough? (sorry for 2019- users)

@hadashiA
Copy link
Owner

Ok. Thanks for the update!

@hadashiA hadashiA merged commit e427251 into hadashiA:master Nov 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IObjectResolver.Instantiate() makes prefab dirty.
2 participants
@yellowisher @hadashiA