Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diagnostic windows are not updating realtime #568

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

PeraSite
Copy link
Contributor

  1. When a container is disposed, the diagnostics window still shows the lifescope and its dependencies. (VContainer Diagnostics window #387)
    In this situation, when user clicks scope/dependency that already disposed to view the details, it shows an error.
    이미지

This PR fixes the error by clearing the diagnostics information when a container is disposed.

  1. On editor's play mode start / end, diagnostic windows are not automatically updated.
    Using EditorApplication.playModeStateChanged, diagnostic windows are conveniently updated.

Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vcontainer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2023 2:18pm

@hadashiA
Copy link
Owner

👍

@hadashiA hadashiA merged commit 123d718 into hadashiA:master Dec 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants