Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore prefab state after instantiation #121

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

cooloon
Copy link
Contributor

@cooloon cooloon commented Feb 11, 2021

Instantiated prefab itself (not clone in the scene) remains inactive even after play mode.
This PR restore prefab state just after instantiation.

If that's not inteded, just drop this PR 😃

@vercel
Copy link

vercel bot commented Feb 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hadashia/vcontainer/9cp0j1mn5
✅ Preview: https://vcontainer-git-fork-cooloon-cooloon-stop-prefab-inactivation.hadashia.vercel.app

@hadashiA
Copy link
Owner

Oh.. ok. You are right, it's not good that the prefab remains inactive.

I would like to add a little work to it.

  • Add some tests
  • I'd like to reduce the number of calls to SetActive a bit (since the callback in the hierarchy is called)

However, I would like to merge this. Thanks!

@hadashiA hadashiA merged commit c72a6be into hadashiA:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants