Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parent reference in the same scene #115

Merged
merged 4 commits into from
Feb 8, 2021
Merged

Conversation

hadashiA
Copy link
Owner

@hadashiA hadashiA commented Feb 8, 2021

In the LifetimeScope inspector, "Parent Type" can be specified, but this was not working in the same scene.

The reasons for this behavior are as follows

  • You need to wait for your turn to Awake, which is complicated.
    • Difficult to report an error when Parent is not found because it waits for Parent to load.
  • There is not much need to divide LifetimeScope into smaller parts.

However, I will still try to fix it so that it works within the same scene.

  • The specification of not working in the same scene seems unexpected.
  • Apparently, there is a requirement to narrow the scope, like Autofac's "Module" Zenject's "Sub Container"!

@vercel
Copy link

vercel bot commented Feb 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hadashia/vcontainer/iwjgew8cw
✅ Preview: https://vcontainer-git-ku-one-scene-relationship.hadashia.vercel.app

@hadashiA hadashiA marked this pull request as ready for review February 8, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant