Merge pull request #109 from hadashiA/ku/register-type

Add non-generic Register(Type)
hadashiA · Feb 3, 2021 · 912dd83 · 912dd83 · vercel · Feb 3, 2021
2 parents 2fb37e5 + aa3117b
commit 912dd83
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/VContainer/Assets/VContainer/Runtime/ContainerBuilder.cs b/VContainer/Assets/VContainer/Runtime/ContainerBuilder.cs
@@ -12,7 +12,7 @@ public interface IContainerBuilder
         object ApplicationOrigin { get; set; }
         bool ContainerExposed { get; set; }
 
-        RegistrationBuilder Register<T>(Lifetime lifetime);
+        RegistrationBuilder Register(Type type, Lifetime lifetime);
         RegistrationBuilder RegisterInstance(object instance);
         RegistrationBuilder Register(RegistrationBuilder registrationBuilder);
 
@@ -49,12 +49,11 @@ public class ContainerBuilder : IContainerBuilder
         public object ApplicationOrigin { get; set; }
         public bool ContainerExposed { get; set; }
 
-
         readonly IList<RegistrationBuilder> registrationBuilders = new List<RegistrationBuilder>();
         List<Action<IObjectResolver>> buildCallbacks;
 
-        public RegistrationBuilder Register<T>(Lifetime lifetime)
-            => Register(new RegistrationBuilder(typeof(T), lifetime));
+        public RegistrationBuilder Register(Type type, Lifetime lifetime)
+            => Register(new RegistrationBuilder(type, lifetime));
 
         public RegistrationBuilder RegisterInstance(object instance)
             => Register(new RegistrationBuilder(instance));

diff --git a/VContainer/Assets/VContainer/Runtime/ContainerBuilderExtensions.cs b/VContainer/Assets/VContainer/Runtime/ContainerBuilderExtensions.cs
@@ -5,6 +5,11 @@ namespace VContainer
 {
     public static class ContainerBuilderExtensions
     {
+        public static RegistrationBuilder Register<T>(
+            this IContainerBuilder builder,
+            Lifetime lifetime)
+            => builder.Register(typeof(T), lifetime);
+
         public static RegistrationBuilder Register<TInterface, TImplement>(
             this IContainerBuilder builder,
             Lifetime lifetime)
@@ -61,7 +66,7 @@ public static RegistrationBuilder RegisterFactory<TParam1, TParam2, TParam3, TPa
             this IContainerBuilder builder,
             Func<TParam1, TParam2, TParam3, TParam4, T> factory)
             => builder.RegisterInstance(factory);
-        
+
         public static RegistrationBuilder RegisterFactory<T>(
             this IContainerBuilder builder,
             Func<IObjectResolver, Func<T>> factoryFactory,