Skip to content

Use ::class pseudo constants in Configuration::getConfigTreeBuilder() #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2020
Merged

Use ::class pseudo constants in Configuration::getConfigTreeBuilder() #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,13 @@

namespace Hackzilla\Bundle\TicketBundle\DependencyInjection;

use Hackzilla\Bundle\TicketBundle\Entity\Ticket;
use Hackzilla\Bundle\TicketBundle\Entity\TicketMessage;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;
use Symfony\Component\Config\Definition\ConfigurationInterface;

/**
* This is the class that validates and merges configuration from your app/config files.
* This is the class that validates and merges configuration from your config files.
*
* To learn more see {@link http://symfony.com/doc/current/cookbook/bundles/extension.html#cookbook-bundles-extension-config-class}
*
Expand Down Expand Up @@ -43,8 +45,8 @@ public function getConfigTreeBuilder()
->defaultValue('messages')
->end()
->scalarNode('user_class')->isRequired()->cannotBeEmpty()->end()
->scalarNode('ticket_class')->cannotBeEmpty()->defaultValue('Hackzilla\Bundle\TicketBundle\Entity\Ticket')->end()
->scalarNode('message_class')->cannotBeEmpty()->defaultValue('Hackzilla\Bundle\TicketBundle\Entity\TicketMessage')->end()
->scalarNode('ticket_class')->cannotBeEmpty()->defaultValue(Ticket::class)->end()
->scalarNode('message_class')->cannotBeEmpty()->defaultValue(TicketMessage::class)->end()
->arrayNode('features')
->addDefaultsIfNotSet()
->children()
Expand Down