Narrow API marking classes as final

Command/AutoClosingCommand.php

@@ -9,6 +9,9 @@
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 
+/**
+ * @final since hackzilla/ticket-bundle 3.x.
+ */
 class AutoClosingCommand extends ContainerAwareCommand
 {
     protected static $defaultName = 'ticket:autoclosing';

Command/TicketManagerCommand.php

@@ -9,6 +9,9 @@
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 
+/**
+ * @final since hackzilla/ticket-bundle 3.x.
+ */
 class TicketManagerCommand extends ContainerAwareCommand
 {
     protected static $defaultName = 'ticket:create';

Component/TicketFeatures.php

@@ -4,6 +4,9 @@
 
 use Hackzilla\Bundle\TicketBundle\Model\TicketFeature\MessageAttachmentInterface;
 
+/**
+ * @final since hackzilla/ticket-bundle 3.x.
+ */
 class TicketFeatures
 {
     private $features;

Controller/TicketAttachmentController.php

@@ -9,6 +9,8 @@
  * Ticket Attachment controller.
  *
  * Download attachments
+ *
+ * @final since hackzilla/ticket-bundle 3.x.
  */
 class TicketAttachmentController extends Controller
 {

Controller/TicketController.php

@@ -15,6 +15,8 @@
 
 /**
  * Ticket controller.
+ *
+ * @final since hackzilla/ticket-bundle 3.x.
  */
 class TicketController extends Controller
 {

DependencyInjection/Compiler/DoctrineOrmMappingsPass.php

@@ -6,6 +6,9 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Definition;
 
+/**
+ * @final since hackzilla/ticket-bundle 3.x.
+ */
 class DoctrineOrmMappingsPass extends \Doctrine\Bundle\DoctrineBundle\DependencyInjection\Compiler\DoctrineOrmMappingsPass
 {
     public function __construct($driver = null, array $namespaces = [], $managerParameters = [], $enabledParameter = false, array $aliasMap = [])

DependencyInjection/Configuration.php

@@ -9,6 +9,8 @@
  * This is the class that validates and merges configuration from your app/config files.
  *
  * To learn more see {@link http://symfony.com/doc/current/cookbook/bundles/extension.html#cookbook-bundles-extension-config-class}
+ *
+ * @final since hackzilla/ticket-bundle 3.x.
  */
 class Configuration implements ConfigurationInterface
 {

DependencyInjection/HackzillaTicketExtension.php

@@ -11,6 +11,8 @@
  * This is the class that loads and manages your bundle configuration.
  *
  * To learn more see {@link http://symfony.com/doc/current/cookbook/bundles/extension.html}
+ *
+ * @final since hackzilla/ticket-bundle 3.x.
  */
 class HackzillaTicketExtension extends Extension
 {

Event/TicketEvent.php

@@ -5,6 +5,9 @@
 use Hackzilla\Bundle\TicketBundle\Model\TicketInterface;
 use Symfony\Component\EventDispatcher\Event;
 
+/**
+ * @final since hackzilla/ticket-bundle 3.x.
+ */
 class TicketEvent extends Event
 {
     protected $ticket;

EventListener/FileSubscriber.php

@@ -10,6 +10,8 @@
  * Class FileSubscriber.
  *
  * Source: https://gist.github.com/hubgit/0cdf96c296f20017fe91#file-filesubscriber-php
+ *
+ * @final since hackzilla/ticket-bundle 3.x.
  */
 class FileSubscriber implements EventSubscriberInterface
 {

EventListener/UserLoad.php

@@ -6,6 +6,9 @@
 use Hackzilla\Bundle\TicketBundle\Model\TicketInterface;
 use Hackzilla\Bundle\TicketBundle\Model\TicketMessageInterface;
 
+/**
+ * @final since hackzilla/ticket-bundle 3.x.
+ */
 class UserLoad
 {
     protected $userRepository;

Form/DataTransformer/StatusTransformer.php

@@ -5,6 +5,9 @@
 use Hackzilla\Bundle\TicketBundle\Entity\TicketMessage;
 use Symfony\Component\Form\DataTransformerInterface;
 
+/**
+ * @final since hackzilla/ticket-bundle 3.x.
+ */
 class StatusTransformer implements DataTransformerInterface
 {
     /**
@@ -19,6 +22,8 @@ public function transform($number)
         if (TicketMessage::STATUS_CLOSED == $number) {
             return 1;
         }
+
+        return null;
     }
 
     /**
@@ -33,5 +38,7 @@ public function reverseTransform($number)
         if (1 == $number) {
             return TicketMessage::STATUS_CLOSED;
         }
+
+        return null;
     }
 }

Form/Type/PriorityType.php

@@ -8,6 +8,9 @@
 use Symfony\Component\HttpKernel\Kernel;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
+/**
+ * @final since hackzilla/ticket-bundle 3.x.
+ */
 class PriorityType extends AbstractType
 {
     public function configureOptions(OptionsResolver $resolver)

Form/Type/StatusType.php

@@ -8,6 +8,9 @@
 use Symfony\Component\HttpKernel\Kernel;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
+/**
+ * @final since hackzilla/ticket-bundle 3.x.
+ */
 class StatusType extends AbstractType
 {
     public function configureOptions(OptionsResolver $resolver)

Form/Type/TicketMessageType.php

@@ -13,6 +13,9 @@
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
+/**
+ * @final since hackzilla/ticket-bundle 3.x.
+ */
 class TicketMessageType extends AbstractType
 {
     protected $userManager;

Form/Type/TicketType.php

@@ -8,6 +8,9 @@
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
+/**
+ * @final since hackzilla/ticket-bundle 3.x.
+ */
 class TicketType extends AbstractType
 {
     protected $ticketClass;

Manager/TicketManager.php

@@ -9,6 +9,9 @@
 use Hackzilla\Bundle\TicketBundle\TicketRole;
 use Symfony\Component\Translation\TranslatorInterface;
 
+/**
+ * @final since hackzilla/ticket-bundle 3.x.
+ */
 class TicketManager implements TicketManagerInterface
 {
     private $translator;

Manager/UserManager.php

@@ -10,6 +10,9 @@
 use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
 use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
 
+/**
+ * @final since hackzilla/ticket-bundle 3.x.
+ */
 class UserManager implements UserManagerInterface
 {
     /**
@@ -59,7 +62,7 @@ public function getCurrentUser()
     public function getUserById($userId)
     {
         if (!$userId) {
-            return;
+            return null;
         }
 
         return $this->userRepository->find($userId);

Tests/Component/TicketFeaturesTest.php

@@ -32,11 +32,10 @@ public function constructProvider()
     /**
      * @dataProvider featureAttachmentProvider
      *
-     * @param array     $features
      * @param string    $class
      * @param bool|null $compare
      */
-    public function testFeatureAttachment($features, $class, $compare)
+    public function testFeatureAttachment(array $features, $class, $compare)
     {
         $obj = new TicketFeatures($features, $class);
 

TicketRole.php

@@ -2,6 +2,9 @@
 
 namespace Hackzilla\Bundle\TicketBundle;
 
+/**
+ * @final since hackzilla/ticket-bundle 3.x.
+ */
 class TicketRole
 {
     const ADMIN = 'ROLE_TICKET_ADMIN';

TwigExtension/TicketFeatureExtension.php

@@ -6,6 +6,9 @@
 use Twig\Extension\AbstractExtension;
 use Twig\TwigFunction;
 
+/**
+ * @final since hackzilla/ticket-bundle 3.x.
+ */
 class TicketFeatureExtension extends AbstractExtension
 {
     private $ticketFeatures;

TwigExtension/TicketGlobalExtension.php

@@ -5,6 +5,9 @@
 use Twig\Extension\AbstractExtension;
 use Twig\Extension\GlobalsInterface;
 
+/**
+ * @final since hackzilla/ticket-bundle 3.x.
+ */
 class TicketGlobalExtension extends AbstractExtension implements GlobalsInterface
 {
     protected $templates = [];