Skip to content

Replace "twig/twig" requirement with "symfony/twig-bundle" #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

phansys
Copy link
Member

@phansys phansys commented Aug 20, 2019

Q A
Branch master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a
  • "symfony/twig-bundle" is required to call render() from controllers;
  • "twig/twig" was moved to conflict section with the constraint <1.34 in order to ensure its namespaced classes are available.

@phansys phansys added the bug label Aug 20, 2019
@phansys phansys requested a review from hackzilla August 20, 2019 10:40
phansys added a commit that referenced this pull request Aug 20, 2019
…" (phansys)

This PR was merged into the master branch.

Discussion
----------

|Q            |A     |
|---          |---   |
|Branch       |master|
|Bug fix?     |yes   |
|New feature? |no    |
|BC breaks?   |no    |
|Deprecations?|no    |
|Tests pass?  |yes   |
|Fixed tickets|n/a   |
|License      |MIT   |
|Doc PR       |n/a   |

* "symfony/twig-bundle" is required to call `render()` from controllers;
* "twig/twig" was moved to `conflict` section with the constraint `<1.34` in order to ensure its namespaced classes are available.

Commits
-------

0723634 Replace "twig/twig" requirement with "symfony/twig-bundle"
@phansys phansys merged commit 0723634 into hackzilla-project:master Aug 20, 2019
@phansys phansys deleted the twig_bundle branch August 20, 2019 10:45
phansys added a commit that referenced this pull request Nov 29, 2019
…ig ticket extensions (phansys)

This PR was merged into the master branch.

Discussion
----------

|Q            |A     |
|---          |---   |
|Branch       |master|
|Bug fix?     |yes   |
|New feature? |no    |
|BC breaks?   |no    |
|Deprecations?|no    |
|Tests pass?  |yes   |
|Fixed tickets|n/a   |
|License      |MIT   |
|Doc PR       |n/a   |

This partially reverts #146.

Commits
-------

094706c Explicitly require "twig/twig" since it is used by the Twig ticket extensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant