Skip to content

Make explicit dependency against "twig/twig" in order to replace usage of spaceless tag, which is deprecated since "1.38" #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make explicit dependency against "twig/twig" in order to replace usage of spaceless tag, which is deprecated since "1.38" #138

wants to merge 1 commit into from

Conversation

phansys
Copy link
Member

@phansys phansys commented Jun 15, 2019 •
edited
Loading

Q A
Branch master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a
  • Make explicit dependency against "twig/twig:^2.9";
  • Changed usages of {% spaceless %} tag, which is deprecated as of Twig 1.38 with {% apply spaceless %} filter, which is available as of Twig 2.9.

@phansys phansys requested a review from hackzilla June 15, 2019 12:40
@phansys
Make explicit dependency against "twig/twig" in order to replace usag…
cdb5582 
…e of `spaceless` tag, which is deprecated since "1.38"
@phansys phansys force-pushed the twig_deprecated_features branch from 73e947c to cdb5582 Compare August 21, 2019 18:34
@phansys phansys added the major This change must be published in a MAJOR release label Jul 1, 2020
@phansys phansys added this to the 4.0 milestone Jul 4, 2020
@phansys phansys mentioned this pull request Oct 27, 2020
Merged
@phansys phansys closed this in 5f04923 Oct 29, 2020
@phansys phansys closed this in #178 Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackzilla hackzilla Awaiting requested review from hackzilla

Assignees
No one assigned
Labels
enhancement major This change must be published in a MAJOR release
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@phansys