Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mermaid to 8.2.3 #1242

Merged
merged 5 commits into from
Jul 29, 2019
Merged

Upgrade mermaid to 8.2.3 #1242

merged 5 commits into from
Jul 29, 2019

Conversation

jackycute
Copy link
Member

to avoid XSS inside the svg tag

Signed-off-by: Max Wu jackymaxj@gmail.com

see issue #1233

to avoid XSS inside the svg tag

Signed-off-by: Max Wu <jackymaxj@gmail.com>
Signed-off-by: Max Wu <jackymaxj@gmail.com>
Signed-off-by: Max Wu <jackymaxj@gmail.com>
@jackycute jackycute force-pushed the feature/upgrade-mermaid-for-xss branch from 4bf2160 to f1680ef Compare July 28, 2019 12:04
@jackycute jackycute requested review from Yukaii and removed request for a60814billy July 28, 2019 12:29
Copy link
Member

@Yukaii Yukaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍾

@jackycute
Copy link
Member Author

Thanks @Yukaii

@jackycute jackycute merged commit ce914ad into develop Jul 29, 2019
@jackycute jackycute deleted the feature/upgrade-mermaid-for-xss branch July 29, 2019 01:31
@Yukaii Yukaii added this to the 1.4.0 Release milestone Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants