Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update & move Danielle Aras' profile for the website project team #7986

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

nchanyal
Copy link
Member

@nchanyal nchanyal commented Mar 10, 2025

Fixes #7938

What changes did you make?

  • Updated the leadership variable for Danielle Aras' profile in _projects/website.md
  • Moved Danielle Aras' new profile up the list in the leadership variable so that it is with the other "Developer Co-Lead" profile

Why did you make the changes (we will use this info to test)?

  • To keep project information up to date so that visitors to the website can find accurate information

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

leadership_team_before

Visuals after changes are applied

leadership_team_after

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b nchanyal-update-danielle-aras-in-project-profile-7938 gh-pages
git pull https://github.com/nchanyal/website.git update-danielle-aras-in-project-profile-7938

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Mar 10, 2025
@DrAcula27 DrAcula27 self-requested a review March 10, 2025 21:28
Copy link
Member

@DrAcula27 DrAcula27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nchanyal Great job on your Good First Issue! Your code passed the ABC's, including:

@rogerioduenas rogerioduenas self-requested a review March 11, 2025 06:24
@rogerioduenas
Copy link
Member

Availability: Monday - Friday, 10:00 AM to 4:00 PM JST
ETA: Friday by 4:00 PM JST

Copy link
Member

@rogerioduenas rogerioduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nchanyal!

Great job with this pull request!

  • The branching was done correctly.
  • Issue number was listed.
  • The PR title is descriptive of the changes.
  • Changes were made correctly in the code.
  • Changes appear correctly on the site
  • _projects/website.md was edited correctly.
  • Relevant images were included to show visual changes.
  • The PR request clearly states what was updated.

Again, great work, and thanks for taking the time to contribute to the website. Congratulations on your good first issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Status: PRs ✅ waiting for merge team
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Website- change Danielle Aras to Co-Lead
3 participants