-
-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update & move Danielle Aras' profile for the website project team #7986
base: gh-pages
Are you sure you want to change the base?
Update & move Danielle Aras' profile for the website project team #7986
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nchanyal Great job on your Good First Issue
! Your code passed the ABC's, including:
- PR is made from the correct branch
- PR links to the correct issue:
- The correct file
_projects/website.md
was edited - No extra edits were made
- Appearance of the website looks good (Chrome and Firefox)
Approved! 👍
Availability: Monday - Friday, 10:00 AM to 4:00 PM JST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nchanyal!
Great job with this pull request!
- The branching was done correctly.
- Issue number was listed.
- The PR title is descriptive of the changes.
- Changes were made correctly in the code.
- Changes appear correctly on the site
_projects/website.md
was edited correctly.- Relevant images were included to show visual changes.
- The PR request clearly states what was updated.
Again, great work, and thanks for taking the time to contribute to the website. Congratulations on your good first issue!
Fixes #7938
What changes did you make?
leadership
variable for Danielle Aras' profile in_projects/website.md
leadership
variable so that it is with the other "Developer Co-Lead" profileWhy did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied