Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserted Search Tip Modal Into the Project Page Below the Filter Dropdown #7985

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from

Conversation

dvernon5
Copy link
Member

@dvernon5 dvernon5 commented Mar 9, 2025

Fixes #7866

What changes did you make?

  • Inserted a Search Tip Link at the below the filter dropdown in Desktop version and in-between the Filter hamburger in Mobile Version.
  • The Search Tip Link consists of a modal, so when Search Tip Link is clicked, a modal will appear with content helping user understands the search bar functionalities better.

Why did you make the changes (we will use this info to test)?

  • To help users understand the boolean operators search bar functionalities.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Prescreen-Desktop
Prescreen-Mobile

Visuals after changes are applied

Search-Tips-Link-Implementation-Desktop
Search-Tips-Implementation-Mobile
Modal-Appearance-Desktop
Modal-Appearance-Mobile

Copy link

github-actions bot commented Mar 9, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b dvernon5-add-search-tips-7866 gh-pages
git pull https://github.com/dvernon5/website.git add-search-tips-7866

@github-actions github-actions bot added role: front end Tasks for front end developers Complexity: Medium P-Feature: Projects page https://www.hackforla.org/projects/ Draft Issue is still in the process of being created size: 0.25pt Can be done in 0.5 to 1.5 hours labels Mar 9, 2025
@dvernon5 dvernon5 changed the title Inserted Search Tip Modal Into the Project Page Below the Filter Dropdown #7866 Inserted Search Tip Modal Into the Project Page Below the Filter Dropdown Mar 9, 2025
@belunatic belunatic self-assigned this Mar 9, 2025
@belunatic
Copy link
Member

belunatic commented Mar 9, 2025

ETA: 3/15/2024 EOD
Avail: 12pm-2pm MWF

@Cloid
Copy link
Member

Cloid commented Mar 10, 2025

ETA: EOD 3/15
Avail: Weekdays 5pm-9pm

@Cloid Cloid self-requested a review March 10, 2025 19:31
@Six5pAdes Six5pAdes self-requested a review March 11, 2025 18:44
@Six5pAdes
Copy link
Member

ETA: 3/14 eod
Avail: weekdays 9am-6pm

Copy link
Member

@Six5pAdes Six5pAdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, @dvernon5! Well done with fixing this issue.

What's Done Well:

  • The issue correctly links.
  • The PR title is informative, as are both the what and why for its changes in the contents.
  • All of the changes made appear correctly on the local environment, both in the code and the resulting updated page.

What Can Be Changed In The Future:

  • removing the default images that are shown included in the screenshot section
    image

Feel free to take the suggestion(s) into account for your next issue/PR. In the meantime, I approve this PR.

@dvernon5
Copy link
Member Author

@Six5pAdes

Thank you for your feedback! I took your advice and removed the default images. Great catch. I will be more attentive next time.

@gmgonzal gmgonzal self-requested a review March 11, 2025 22:13
@gmgonzal
Copy link
Member

ETA: 3/11

@daras-cu daras-cu removed the Draft Issue is still in the process of being created label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Projects page https://www.hackforla.org/projects/ role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Status: PR Needs review
Development

Successfully merging this pull request may close these issues.

Add Search Tips Feature to Projects Page
6 participants