-
-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inserted Search Tip Modal Into the Project Page Below the Filter Dropdown #7985
base: gh-pages
Are you sure you want to change the base?
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
ETA: 3/15/2024 EOD |
ETA: EOD 3/15 |
ETA: 3/14 eod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, @dvernon5! Well done with fixing this issue.
What's Done Well:
- The issue correctly links.
- The PR title is informative, as are both the what and why for its changes in the contents.
- All of the changes made appear correctly on the local environment, both in the code and the resulting updated page.
What Can Be Changed In The Future:
- removing the default images that are shown included in the screenshot section
image
Feel free to take the suggestion(s) into account for your next issue/PR. In the meantime, I approve this PR.
Thank you for your feedback! I took your advice and removed the default images. Great catch. I will be more attentive next time. |
ETA: 3/11 |
Fixes #7866
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied