Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added feature flag using useFeatureFlag hook #1827

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,8 @@ dotenv
# required for GitHub action to build react app.
!/client/.env

/client/.env.local

.eslintcache

# End of project-specific exclusions
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import {
} from "../../../../appReducer";
import "mapbox-gl/dist/mapbox-gl.css";
import { useNavigate, useLocation } from "react-router-dom";
import useFeatureFlag from "hooks/useFeatureFlag";

const ResultsMap = (
{
Expand Down Expand Up @@ -78,6 +79,8 @@ const ResultsMap = (
const regionGeoJSON = neighborhood?.geojson;
const startIconCoordinates = searchCoordinates || userCoordinates;

const hasAdvancedFilterFeatureFlag = useFeatureFlag("advancedFilter");

useEffect(() => {
analytics.postEvent("showMap");
}, []);
Expand Down Expand Up @@ -202,15 +205,18 @@ const ResultsMap = (
<Map.Layer {...regionBorderStyle} />
</Map.Source>
)}
<Button
variant="outlined"
onClick={searchMapArea}
size="small"
className={classes.searchButton}
disabled={loading}
>
Search this area
</Button>

{!hasAdvancedFilterFeatureFlag && (
<Button
variant="outlined"
onClick={searchMapArea}
size="small"
className={classes.searchButton}
disabled={loading}
>
Search this area
</Button>
)}
</ReactMapGL>
);
};
Expand Down
5 changes: 5 additions & 0 deletions client/src/hooks/useFeatureFlag.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
export default function useFeatureFlag(flagName) {
const featureFlags = JSON.parse(process.env.REACT_APP_FEATURE_FLAGS || "[]");

return featureFlags.includes(flagName);
}