Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated HTML to MUI components for Home comp #1840

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

jng34
Copy link
Member

@jng34 jng34 commented Jan 21, 2025

Fixes #1717

What changes did you make and why did you make them ?

  • Replaced HTML form tag with MUI FormControl component
  • Replaced HTML label tag with MUI Typography component
  • Replaced HTML select tag with MUI Select component, and mapped each event onto a MenuItem component
  • Removed old style of adding a --Select One-- option; made it the default value for the MUI Select component
  • Added CSS styling to match original CSS for HTML components
  • WHY: To modernize frontend components with MUI

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied before screen 1 before screen 2 before screen 3
Visuals after changes are applied after screen 1 after screen 2 after screen 3

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jng34-updateHTMLtoMUIforHomeComp development
git pull https://github.com/jng34/VRMS.git updateHTMLtoMUIforHomeComp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update HTML components to MUI: ./src/pages/Home.js
1 participant