Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cognito redirect ur ls configurable #524

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

stevbark
Copy link
Collaborator

Should fix the redirect issue when we update the URL value in AWS.

api/.env.example Outdated
COGNITO_ACCESS_KEY=
URL=http://localhost:4040
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more descriptive name would help me understand the purpose of this variable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@paulespinosa
Copy link
Member

This change is for Issue #503, right?

@stevbark
Copy link
Collaborator Author

This change is for Issue #503, right?

yes. #503

@ju1es
Copy link
Member

ju1es commented Jun 20, 2023

sorry in advance if I'm not understanding this correctly! but what's the purpose of .env.example ? if it's the .env that will run in production ('.env.example' then is a bit misleading), i think we'd specify environment variables in the docker file right? I started cooking up a config system that'll generate at runtime,

https://github.com/hackforla/HomeUniteUs/pull/527/files

maybe we add this there?

@paulespinosa
Copy link
Member

paulespinosa commented Jun 21, 2023

@ju1es

but what's the purpose of .env.example ?

My understanding is that it's a file that we can check into version control (git) to demonstrate the environment variables that need to be set within an deployment environment without the actual values (secrets). Different environments (local dev, qa, stage, prod) should have different values.

i think we'd specify environment variables in the docker file right?

If the .env file exists when building the docker image, it will be pulled into the docker image and used by the application when it starts up. I imagine the prod version of the .env file is stored somewhere in AWS that the continuous integration build can access. The CI process is something I'm not familiar with yet, though.

@stevbark
Copy link
Collaborator Author

New changes pushed. more descriptive name added.

@stevbark stevbark merged commit fdf9f07 into main Jun 21, 2023
@stevbark stevbark linked an issue Jun 21, 2023 that may be closed by this pull request
@Joshua-Douglas Joshua-Douglas deleted the Cognito-redirect-URLs-configurable branch December 12, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Cognito redirect URLs configurable in web service
3 participants