Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 502 error on warning API #680

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Fix 502 error on warning API #680

merged 1 commit into from
Nov 29, 2023

Conversation

faizpuru
Copy link
Contributor

Use the new API to request warnings

@faizpuru faizpuru changed the title fix 502 error on warning api DRAFT: fix 502 error on warning api Nov 15, 2023
@faizpuru faizpuru marked this pull request as draft November 15, 2023 10:21
Quentame
Quentame reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉
The fix is only this, cool !
Did not have time to check before.

tests/test_warning.py Outdated Show resolved Hide resolved
tests/test_warning.py Show resolved Hide resolved
tests/test_warning.py Show resolved Hide resolved
@Quentame Quentame mentioned this pull request Nov 15, 2023
Closed
@faizpuru faizpuru force-pushed the fix_warning_API_URL branch from 534e53f to f8a73b5 Compare November 15, 2023 11:49
@faizpuru faizpuru changed the title DRAFT: fix 502 error on warning api fix 502 error on warning api Nov 15, 2023
@faizpuru faizpuru marked this pull request as ready for review November 15, 2023 11:52
@faizpuru
Copy link
Contributor Author

faizpuru commented Nov 15, 2023 •
edited
Loading

I updated my code. The phenomenon id returned by meteo france is now a string. There should be no more typing errors.

@faizpuru faizpuru force-pushed the fix_warning_API_URL branch 2 times, most recently from 14d05ce to 3fb0da7 Compare November 15, 2023 14:01
@faizpuru
Copy link
Contributor Author

Any news ?

@Quentame Quentame force-pushed the fix_warning_API_URL branch from 3fb0da7 to 2f13296 Compare November 29, 2023 15:41
@Quentame Quentame force-pushed the fix_warning_API_URL branch from 2f13296 to 7e56f74 Compare November 29, 2023 16:01
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Quentame Quentame changed the title fix 502 error on warning api Fix 502 error on warning API Nov 29, 2023
@Quentame Quentame merged commit 6ccf7d5 into hacf-fr:master Nov 29, 2023
2 checks passed
This was referenced Nov 29, 2023
Closed
Closed
Open
@Quentame Quentame mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quentame Quentame Quentame approved these changes

@oncleben31 oncleben31 Awaiting requested review from oncleben31 oncleben31 is a code owner

@dx44 dx44 Awaiting requested review from dx44 dx44 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faizpuru @Quentame