Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom types #95

Merged
merged 15 commits into from
Jan 3, 2022
Merged

Custom types #95

merged 15 commits into from
Jan 3, 2022

Conversation

alfonsorr
Copy link
Member

No description provided.

eruizalo
eruizalo requested changes Oct 18, 2021
View reviewed changes
Copy link
Collaborator

@eruizalo eruizalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review my comments please

@alfonsorr alfonsorr added the enhancement New feature or request label Oct 26, 2021
@alfonsorr alfonsorr self-assigned this Nov 10, 2021
@codecov
Copy link

codecov bot commented Dec 23, 2021 •
edited
Loading

Codecov Report

Merging #95 (00480c6) into main (28edbb3) will increase coverage by 3.22%.
The diff coverage is 94.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   91.63%   94.84%   +3.22%     
==========================================
  Files          39       41       +2     
  Lines         609      698      +89     
  Branches        9        9              
==========================================
+ Hits          558      662     +104     
+ Misses         51       36      -15
Impacted Files Coverage Δ
core/src/main/scala/doric/doric.scala 90.91% <ø> (ø)
...main/scala/doric/implicitConversions/package.scala 75.00% <0.00%> (-25.00%) ⬇️
core/src/main/scala/doric/sem/TransformOps.scala 75.00% <0.00%> (+2.27%) ⬆️
...ore/src/main/scala/doric/syntax/ArrayColumns.scala 88.00% <0.00%> (-3.67%) ⬇️
core/src/main/scala/doric/syntax/DStructs.scala 100.00% <ø> (ø)
...re/src/main/scala/doric/syntax/StringColumns.scala 100.00% <ø> (ø)
...src/main/scala/doric/syntax/TimestampColumns.scala 80.00% <ø> (ø)
core/src/main/scala/doric/DoricColumn.scala 77.14% <88.89%> (+3.07%) ⬆️
core/src/main/scala/doric/types/SparkType.scala 93.65% <97.78%> (+1.98%) ⬆️
core/src/main/scala/doric/sem/CollectOps.scala 100.00% <100.00%> (+75.00%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28edbb3...00480c6. Read the comment docs.

@alfonsorr alfonsorr requested review from eruizalo and removed request for eruizalo December 30, 2021 15:38
eruizalo
eruizalo requested changes Dec 31, 2021
View reviewed changes
docs/docs/docs/custom.md Outdated Show resolved Hide resolved
docs/docs/docs/custom.md Outdated Show resolved Hide resolved
docs/docs/docs/custom.md Show resolved Hide resolved
docs/docs/docs/custom.md Show resolved Hide resolved
core/src/test/scala/doric/types/SparkTypeSpec.scala Show resolved Hide resolved
core/src/test/scala/doric/Equalities.scala Outdated Show resolved Hide resolved
core/src/main/scala/doric/types/SparkType.scala Show resolved Hide resolved
core/src/main/scala/doric/DoricColumn.scala Show resolved Hide resolved
core/src/main/scala/doric/implicitConversions/package.scala Show resolved Hide resolved
core/src/main/scala/doric/types/LiteralSparkType.scala Show resolved Hide resolved
alfonsorr and others added 2 commits January 1, 2022 20:49
@alfonsorr @eruizalo
Update docs/docs/docs/custom.md
e1f438c 
Co-authored-by: Eduardo Ruiz Alonso <edu.r26@gmail.com>
@alfonsorr @eruizalo
Update docs/docs/docs/custom.md
fb11f7b 
Co-authored-by: Eduardo Ruiz Alonso <edu.r26@gmail.com>
This was referenced Jan 1, 2022
Open
Open
@alfonsorr @eruizalo
Update core/src/test/scala/doric/Equalities.scala
00480c6 
Co-authored-by: Eduardo Ruiz Alonso <edu.r26@gmail.com>
@alfonsorr alfonsorr merged commit 7b20fff into hablapps:main Jan 3, 2022
@eruizalo eruizalo mentioned this pull request Jul 15, 2022
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eruizalo eruizalo eruizalo approved these changes

@jserranohidalgo jserranohidalgo jserranohidalgo left review comments

Assignees

@alfonsorr alfonsorr

Labels
enhancement New feature or request
Projects
Habla doric
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfonsorr @jserranohidalgo @eruizalo