Fix/hof structs combined error and improve resolution of unresolved columns #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
spark_2.4
alfonsorr
force-pushed
the
fix/hof_structs
branch
from
d1b305d
to
f3339fe
Compare
Codecov Report
@@ Coverage Diff @@
## main #227 +/- ##
==========================================
+ Coverage 96.39% 96.83% +0.44%
==========================================
Files 53 53
Lines 831 946 +115
Branches 9 11 +2
==========================================
+ Hits 801 916 +115
Misses 30 30
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eruizalo
requested changes
Jun 13, 2022
core/src/test/spark_3.0_3.1_3.2/scala/doric/syntax/MapColumns3xSpec.scala
Show resolved
Hide resolved
|
Still pending some optimizations in creating the lambdas |
alfonsorr
force-pushed
the
fix/hof_structs
branch
from
80c1000
to
a82b36c
Compare
…lects. CurrentDate now is resolved in creation.
…"asDoric" in some basic cases.
alfonsorr
force-pushed
the
fix/hof_structs
branch
from
a82b36c
to
e00578f
Compare
|
@eruizalo Ready for your review 😄 |
alfonsorr
changed the title
eruizalo
requested changes
Jun 21, 2022
core/src/test/spark_3.0_3.1_3.2/scala/doric/syntax/ArrayColumns3xSpec.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Eduardo Ruiz Alonso <edu.r26@gmail.com>
Co-authored-by: Eduardo Ruiz Alonso <edu.r26@gmail.com>
Co-authored-by: Eduardo Ruiz Alonso <edu.r26@gmail.com>
Added zipper to improve zipWith syntax
eruizalo
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOF functions for arrays and maps couldn't be used combined with Row children due to problems with lambda column references.
Added also flatten for collections of collections
Added currentDate alternative that allows setting the Return type other than Date
Fixes #225