Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the verify pipeline to get macOS building again #9077

Closed
wants to merge 1 commit into from

Conversation

jasonheath
Copy link
Contributor

@jasonheath jasonheath commented Oct 27, 2023

Problem

Our buildkit pipelines are failing because the macOS install script step is timing out.

Root Cause

Solution

  • Change the timeout for the step to 60m matching the timeout for other macOS steps

While we're here...

@netlify
Copy link

netlify bot commented Oct 27, 2023

👷 Deploy Preview for chef-habitat processing.

Name Link
🔨 Latest commit 7f475b7
🔍 Latest deploy log https://app.netlify.com/sites/chef-habitat/deploys/6564fa721372ce0007bf8aad

@jasonheath jasonheath force-pushed the jah/fix-verify-pipeline-for-macos branch from 653e7f4 to 1215f35 Compare October 27, 2023 13:39
Signed-off-by: Jason Heath <jason.heath@progress.com>
@jasonheath jasonheath force-pushed the jah/fix-verify-pipeline-for-macos branch 2 times, most recently from c5d9430 to 7f475b7 Compare November 27, 2023 20:24
@jasonheath
Copy link
Contributor Author

The cargo audit failure is due to the yanking of many version of the ahash crate. We don't have a direct dependency on ahash so we're waiting for updates from the projects leveraging ahash. This is commit is one of those projects and the relationship to ahash changes a bit but actix needs changes and I think more upstream changes may be needed in hashbrown before tokio clears.

@jasonheath jasonheath marked this pull request as ready for review November 27, 2023 21:40
@jasonheath jasonheath requested a review from mwrock November 27, 2023 21:41
inherit-environment-vars: true
timeout_in_minutes: 10
timeout_in_minutes: 60
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this bump.

@mwrock
Copy link
Contributor

mwrock commented Nov 27, 2023

The audit failure should be cleared after #9080 is merged.

@mwrock
Copy link
Contributor

mwrock commented Nov 28, 2023

I went ahead and merged #9080 to clear up all the audit failures which also bumped macos so I am closing this but thanks for submitting this because it helped me realize what #9080 needed to pass a few weeks ag.

@mwrock mwrock closed this Nov 28, 2023
@jasonheath jasonheath deleted the jah/fix-verify-pipeline-for-macos branch November 28, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants