Skip to content
This repository has been archived by the owner on Nov 29, 2022. It is now read-only.

Prompt not correctly displayed #35

Closed
mkuurstra opened this issue Jun 1, 2018 · 8 comments
Closed

Prompt not correctly displayed #35

mkuurstra opened this issue Jun 1, 2018 · 8 comments
Labels
bug Something isn't working

Comments

@mkuurstra
Copy link

Describe the bug
I noticed the switch to PCRE2 and wanted to try out the performance increase that comes with it. But sadly it doesn't work correctly. My prompt doesn't completely appear and when logged in to routers using tab completion causes it to eat the last character of the word.

The ct binary I build around 2 weeks ago doesn't have this issue. It was build somewhere after changing to PCRE, help displays v0.05

Screenshots
This happens if I open CT and just press enter a few times:

[me@v-server ~]$ ./git/ChromaTerm--/src/ct
[me@v-server ~]$
[me@v-server ~
[me@v-server ~

Environment (please complete the following information):

  • OS: centos 7
  • Version 7.5.1804 (Core)

Additional context
I tried to check if this bug is still present in the development branch but there seem to be some major changes in how CT-- is used there. I couldn't get CT-- working |(prompt was displayed but any command used doesn't display output) but your'e probably still working on that.

@hSaria
Copy link
Owner

hSaria commented Jun 1, 2018

@marvink87

I'll try to recreate the issue on my end.

  • Could you share your .chromatermrc file please?
  • Put %config {HIGHLIGHT} {OFF} in your .chromatermrc file, and check to see if the issue still exists. (Remove this line once you're done with this test.)
  • Could you put %config {CONVERT META} {ON} in your .chromatermrc file, recreate the issue, then send that output of your terminal (it'll have some escaped codes that will help me eliminate some of the possible causes). (Remove this line once you're done with this test.)

And you're right, the development branch is something slightly different. That one reads from a pipe (stdin) instead of spawning a child process. In other words, it's like GREP or SED, so the development would be ssh some_router | ct
For now, don't use the development branch because it doesn't have an interactive CT-- prompt (once the program started, you cannot modify the settings). If you're okay with that, then you can go ahead and use it since it's even more stable than v0.1.0.

@hSaria
Copy link
Owner

hSaria commented Jun 1, 2018

Just saw the bug when auto-completing. I'll fix it ASAP.

@hSaria
Copy link
Owner

hSaria commented Jun 1, 2018

The bug isn't present in the development branch, but again, that doesn't have the interactive CT-- prompt.

@mkuurstra
Copy link
Author

No difference when changing highlight to OFF
When setting convert meta to off the output looks like this:

[kuurstra@v-netjump001 ~]$ ./git/ChromaTerm--/src/ct
[kuurstra@v-netjump001 ~]$ \r\r
[kuurstra@v-netjump001 \r\r
[kuurstra@v-netjump001 \r\r

This is my config: https://gist.github.com/marvink87/1405cc9193091b3da99e70de52544c62
Already tested the config by commenting out all the HIGHLIGHT rules

@hSaria
Copy link
Owner

hSaria commented Jun 1, 2018

@marvink87 could you try now using the patch-1 branch?

git clone -b patch-1 https://github.com/hSaria/ChromaTerm--
cd ChromaTerm--/src && ./configure && make

@mkuurstra
Copy link
Author

Logged into a few different devices and everything seems to be working again. 👍

@hSaria
Copy link
Owner

hSaria commented Jun 1, 2018

Great. I'll soon release this as v0.1.1

@hSaria hSaria closed this as completed in 4fcdd2f Jun 1, 2018
hSaria added a commit that referenced this issue Jun 1, 2018
@hSaria hSaria mentioned this issue Jun 1, 2018
@hSaria
Copy link
Owner

hSaria commented Jun 1, 2018

v0.1.1 released; you can go back to the master branch. Thanks a lot for submitting this issue.

@hSaria hSaria added the bug Something isn't working label Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants